linux-kernel - Re: [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <201608301440.52481.arnd@arndb.de>
Date:   Tue, 30 Aug 2016 14:40:52 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     Sean Paul <seanpaul@...gle.com>, bskeggs@...hat.com,
        Dave Airlie <airlied@...ux.ie>,
        "dri-devel" <dri-devel@...ts.freedesktop.org>,
        nouveau@...ts.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        xie.baoyou@....com.cn
Subject: Re: [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static

On Tuesday 30 August 2016, Baoyou Xie wrote:
> On 30 August 2016 at 00:01, Sean Paul <seanpaul@...gle.com> wrote:
> 
> > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie@...aro.org> wrote:
> > > We get 1 warning when build kernel with W=1:
> > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no
> > previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
> > >
> > > In fact, this function is only used in the file in which it is
> > > declared and don't need a declaration, but can be made static.
> > > so this patch marks this function with 'static'.
> > >
> >
> > It would make things a lot easier if you either consolidated all of
> > these static changes into one patch, or released them as a series.
> >
> >
> Do you mean that I need to consolidate all of them into one patch this
> time? or next time?

I'd suggest consolidating the 'nouveau' changes into a single patch,
as this is one (very big) driver and resend that one.

	Arnd