linux-kernel - Re: [PATCH v3 2/3] tracing: Add trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160830095238.57d4e781@gandalf.local.home>
Date:   Tue, 30 Aug 2016 09:52:38 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Binoy Jayan <binoy.jayan@...aro.org>
Cc:     Daniel Wagner <daniel.wagner@...-carit.de>,
        Ingo Molnar <mingo@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        linaro-kernel@...ts.linaro.org, Carsten Emde <C.Emde@...dl.org>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        Masami <masami.hiramatsu@...aro.org>
Subject: Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints

On Tue, 30 Aug 2016 15:11:26 +0530
Binoy Jayan <binoy.jayan@...aro.org> wrote:

> On 29 August 2016 at 15:13, Daniel Wagner <daniel.wagner@...-carit.de> wrote:
> > Hi Binoy,
> >
> > Some minor nitpicking.
> >
> > As Steven already pointed out, the cpu field is available in all traces.
> > It's one of the predefined fields (see
> > kernel/trace/trace_events.c/trace_define_generic_fields()). Just drop it.
> >  
> 
> Hi Daniel,
> 
> Thank you for looking at the patch again. When I do not use cpu as a field,
> I am not able to make it part of the key or value fields. I can only
> use cpu in the
> filter predicate.
> 
> For example, the following trigger does not seem to work:
> 'hist:key=ltype,cpu:val=latency:sort=ltype,cpu if ltype==0'
> 
> But the following works:
> 'hist:key=ltype,latency:val=hitcount:sort=latency if cpu==1'

What about using "CPU" (all caps)? Look at
kernel/trace/trace_events_filter.c for FILTER_CPU.

Lets not add fields when we can fix the generic code to process these.

Thanks!

-- Steve