linux-kernel - Re: [PATCH 2/2] clk: mvebu: dynamically allocate resources in Armada CP110 system controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2016 16:15:32 +0200
From:   Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:     Marcin Wojtas <mw@...ihalf.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-clk@...r.kernel.org, sboyd@...eaurora.org,
        mturquette@...libre.com, sebastian.hesselbarth@...il.com,
        andrew@...n.ch, jason@...edaemon.net,
        gregory.clement@...e-electrons.com, nadavh@...vell.com,
        alior@...vell.com, tn@...ihalf.com, jaz@...ihalf.com
Subject: Re: [PATCH 2/2] clk: mvebu: dynamically allocate resources in
 Armada CP110 system controller

Hello,

On Tue, 23 Aug 2016 08:26:49 +0200, Marcin Wojtas wrote:
> Original commit, which added support for Armada CP110 system controller
> used global variables for storing all clock information. It worked
> fine for Armada 7k SoC, with single CP110 block. After dual-CP110 Armada 8k
> was introduced, the data got overwritten and corrupted.
> 
> This patch fixes the issue by allocating resources dynamically in the
> driver probe and storing it as platform drvdata.
> 
> Fixes: d3da3eaef7f4 ("clk: mvebu: new driver for Armada CP110 system ...")

Adding:

CC: <stable@...r.kernel.org>

here would be useful.

> 
> Signed-off-by: Marcin Wojtas <mw@...ihalf.com>

Other than that:

Tested-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
 (on Armada 8K hardware)
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>

Thanks a lot for fixing the crap that I initially wrote :-/

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com