linux-kernel - RE: [RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner field in ns2_pci_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3c59d19c72f896e27e0d99695124be4@mail.gmail.com>
Date:   Tue, 30 Aug 2016 19:55:33 +0530
From:   Pramod Kumar <pramod.kumar@...adcom.com>
To:     Axel Lin <axel.lin@...ics.com>,
        Kishon Vijay Abraham I <kishon@...com>
Cc:     Andrew Lunn <andrew@...n.ch>, Jon Mason <jonmason@...adcom.com>,
        linux-kernel@...r.kernel.org
Subject: RE: [RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner
 field in ns2_pci_phy_ops

> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@...ics.com]
> Sent: 30 August 2016 19:24
> To: Kishon Vijay Abraham I
> Cc: Pramod Kumar; Andrew Lunn; Jon Mason; linux-kernel@...r.kernel.org;
> Axel Lin
> Subject: [RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner
> field in ns2_pci_phy_ops
>
> Add missing .owner field in ns2_pci_phy_ops, which is used for
refcounting.
> While at it, also makes ns2_pci_phy_ops const as it's never get
modified.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> Reviewed-and-tested-by: Jon Mason <jon.mason@...adcom.com>
> ---
> This was sent on http://www.spinics.net/lists/netdev/msg383514.html
> Resent on https://lkml.org/lkml/2016/8/12/659
>  drivers/phy/phy-bcm-ns2-pcie.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-bcm-ns2-pcie.c
b/drivers/phy/phy-bcm-ns2-pcie.c
> index ee61772..4c7d11d 100644
> --- a/drivers/phy/phy-bcm-ns2-pcie.c
> +++ b/drivers/phy/phy-bcm-ns2-pcie.c
> @@ -47,8 +47,9 @@ err:
>  	return rc;
>  }
>
> -static struct phy_ops ns2_pci_phy_ops = {
> +static const struct phy_ops ns2_pci_phy_ops = {
>  	.init = ns2_pci_phy_init,
> +	.owner = THIS_MODULE,
>  };
>
>  static int ns2_pci_phy_probe(struct mdio_device *mdiodev)
> --

Looks fine to me.

Reviewed-by: Pramod Kumar <pramodku@...adcom.com>

> 2.5.0