linux-kernel - Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160830145756.GA2471@linux.vnet.ibm.com>
Date:   Tue, 30 Aug 2016 20:27:56 +0530
From:   Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Dmitry Safonov <dsafonov@...tuozzo.com>,
        linux-kernel@...r.kernel.org, mingo@...hat.com,
        luto@...capital.net, tglx@...utronix.de, hpa@...or.com,
        x86@...nel.org, 0x7f454c46@...il.com, oleg@...hat.com,
        viro@...iv.linux.org.uk
Subject: Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe

* Steven Rostedt <rostedt@...dmis.org> [2016-08-29 18:58:13]:

> On Thu, 25 Aug 2016 18:21:09 +0300
> Dmitry Safonov <dsafonov@...tuozzo.com> wrote:
> 
> > It's useless. Before:
> >   [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> >   [tracing]# echo 'p:test a:0x0' >> uprobe_events
> >   -bash: echo: write error: No such file or directory
> >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> >   -bash: echo: write error: Invalid argument
> > 
> > After:
> >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> >   -bash: echo: write error: No such file or directory
> > 
> > Signed-off-by: Dmitry Safonov <dsafonov@...tuozzo.com>
> 
> Acked-by: Steven Rostedt <rostedt@...dmis.org>

Agree.

Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>

-- 
Thanks and Regards
Srikar Dronamraju