linux-kernel - Re: [PATCH v3] time: alarmtimer: Add the trcepoints for alarmtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160830114230.2f4bce51@gandalf.local.home>
Date:   Tue, 30 Aug 2016 11:42:30 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     Ingo Molnar <mingo@...hat.com>,
        John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Mark Brown <broonie@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] time: alarmtimer: Add the trcepoints for alarmtimer

On Tue, 30 Aug 2016 19:50:20 +0800
Baolin Wang <baolin.wang@...aro.org> wrote:

> Hi,
> 
> On 22 August 2016 at 12:23, Baolin Wang <baolin.wang@...aro.org> wrote:
> > For system debugging, we usually want to know who sets one alarm timer, the
> > time of the timer, when the timer started and fired and so on. Thus adding
> > tracepoints can help us trace the alarmtimer information.
> >
> > For example, when we debug the system supend/resume, if the system is always
> > resumed by RTC alarm, we can find out which process set the alarm timer to
> > resume system by below trace log:
> >
> > ......
> > Binder:2976_6-3473  [005] d..2  1076.587732: alarmtimer_start: process:Binder:2976_6
> > alarmtimer type:ALARM_BOOTTIME expires:1234154000000 time: 1970-1-1 0:20:35
> >
> > Binder:2976_7-3480  [002] d..2  1076.592707: alarmtimer_cancel: process:Binder:2976_7
> > alarmtimer type:ALARM_BOOTTIME expires:1325463060000000000 time: 2012-1-2 0:11:0
> >
> > Binder:2976_7-3480  [002] d..2  1076.592731: alarmtimer_start: process:Binder:2976_7
> > alarmtimer type:ALARM_BOOTTIME expires:1325378040000000000 time: 2012-1-1 0:34:0
> >
> > system_server-2976  [003] d..2  1076.605587: alarmtimer_cancel: process:system_server
> > alarmtimer type:ALARM_BOOTTIME expires:1234154000000 time: 1970-1-1 0:20:35
> >
> > system_server-2976  [003] d..2  1076.605608: alarmtimer_start: process:system_server
> > alarmtimer type:ALARM_BOOTTIME expires:1234155000000 time: 1970-1-1 0:20:35
> >
> > system_server-3000  [002] ...1  1087.737565: alarmtimer_suspend: alarmtimer type:ALARM_BOOTTIME
> > expires time: 2012-1-1 0:34:0
> > ......
> >
> > From the trace log, we can find out the 'Binder:2976_7' process set one alarm
> > timer which resumes the system.  
> 
> Do you have any comments about this patch? Thanks.

Looks fine to me.

Acked-by: Steven Rostedt <rostedt@...dmis.org>

Now you need to get the time maintainers to accept it.

Thanks!

-- Steve

> 
> >
> > Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> > ---