lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Aug 2016 09:21:30 -0700 From: Vineet Gupta <Vineet.Gupta1@...opsys.com> To: Alexey Brodkin <Alexey.Brodkin@...opsys.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: "linux-snps-arc@...ts.infradead.org" <linux-snps-arc@...ts.infradead.org>, Arnaldo Carvalho de Melo <acme@...hat.com>, Wang Nan <wangnan0@...wei.com>, Jiri Olsa <jolsa@...nel.org>, He Kuang <hekuang@...wei.com>, Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>, Namhyung Kim <namhyung@...nel.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Zefan Li <lizefan@...wei.com>, "pi3orama@....com" <pi3orama@....com> Subject: Re: [PATCH] perf tools: Fix static building On 08/22/2016 10:35 AM, Alexey Brodkin wrote: > With commit e3d09ec8126f ("tools lib traceevent: Export dynamic symbols > used by traceevent plugins") we started to add "--dynamic-list" in > LDFLAGS. One side-effect of that was inability to build really > statically-linked perf. > > I.e. even if "LDFLAGS=-static" were passed on perf building command-line > it had no effect and perf was built dynamically. > > This change disables setup of "--dynamic-list" if LDFLAGS contains > "-static" option. > > Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com> > Cc: Arnaldo Carvalho de Melo <acme@...hat.com> > Cc: Vineet Gupta <vgupta@...opsys.com> > Cc: Wang Nan <wangnan0@...wei.com> > Cc: Jiri Olsa <jolsa@...nel.org> > Cc: He Kuang <hekuang@...wei.com> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> > Cc: Namhyung Kim <namhyung@...nel.org> > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl> > Cc: Zefan Li <lizefan@...wei.com> > Cc: pi3orama@....com > --- > tools/perf/Makefile.perf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 2d908750..e9acc7c 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -236,7 +236,9 @@ LIBTRACEEVENT = $(TE_PATH)libtraceevent.a > export LIBTRACEEVENT > > LIBTRACEEVENT_DYNAMIC_LIST = $(TE_PATH)libtraceevent-dynamic-list > +ifeq ($(filter -static,$(LDFLAGS)),) > LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS = -Xlinker --dynamic-list=$(LIBTRACEEVENT_DYNAMIC_LIST) > +endif > > LIBAPI = $(API_PATH)libapi.a > export LIBAPI Gentle Ping while Alexey is away on vacation ! Arnaldo are you ok with this patch. Thx, -Vineet
Powered by blists - more mailing lists