linux-kernel - Re: [PATCH] pwm: pwm-tipwmss: Remove all pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ec09503-e180-7b6a-b724-a80693896ab2@ti.com>
Date:   Tue, 30 Aug 2016 10:18:35 +0530
From:   Vignesh R <vigneshr@...com>
To:     Thierry Reding <thierry.reding@...il.com>
CC:     Jyri Sarha <jsarha@...com>, Dave Gerlach <d-gerlach@...com>,
        <linux-omap@...r.kernel.org>, <linux-pwm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pwm: pwm-tipwmss: Remove all pm_runtime gets and puts
 from the driver



On Monday 08 August 2016 03:39 PM, Vignesh R wrote:
> From: Jyri Sarha <jsarha@...com>
> 
> Remove all pm_runtime gets and puts, and dummy pm_ops, from the
> pwm-tipwmss driver as there is no direct hardware access. The runtime PM
> needs to be enabled, so that the runtime PM framework takes care of
> enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
> EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
> idle when none of the submodules are in use.
> 
> Signed-off-by: Jyri Sarha <jsarha@...com>
> Signed-off-by: Vignesh R <vigneshr@...com>
> ---


Gentle ping....

>  drivers/pwm/pwm-tipwmss.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/pwm/pwm-tipwmss.c
> index 829f4991c96f..7fa85a1604da 100644
> --- a/drivers/pwm/pwm-tipwmss.c
> +++ b/drivers/pwm/pwm-tipwmss.c
> @@ -34,7 +34,6 @@ static int pwmss_probe(struct platform_device *pdev)
>  	struct device_node *node = pdev->dev.of_node;
>  
>  	pm_runtime_enable(&pdev->dev);
> -	pm_runtime_get_sync(&pdev->dev);
>  
>  	/* Populate all the child nodes here... */
>  	ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
> @@ -46,31 +45,13 @@ static int pwmss_probe(struct platform_device *pdev)
>  
>  static int pwmss_remove(struct platform_device *pdev)
>  {
> -	pm_runtime_put_sync(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PM_SLEEP
> -static int pwmss_suspend(struct device *dev)
> -{
> -	pm_runtime_put_sync(dev);
> -	return 0;
> -}
> -
> -static int pwmss_resume(struct device *dev)
> -{
> -	pm_runtime_get_sync(dev);
> -	return 0;
> -}
> -#endif
> -
> -static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);
> -
>  static struct platform_driver pwmss_driver = {
>  	.driver	= {
>  		.name	= "pwmss",
> -		.pm	= &pwmss_pm_ops,
>  		.of_match_table	= pwmss_of_match,
>  	},
>  	.probe	= pwmss_probe,
> 

-- 
Regards
Vignesh