linux-kernel - Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3c5e9ca-2381-71e0-5b03-5bad68868b97@codeaurora.org>
Date:   Tue, 30 Aug 2016 13:37:29 -0400
From:   Sinan Kaya <okaya@...eaurora.org>
To:     Vinod Koul <vinod.koul@...el.com>
Cc:     dmaengine@...r.kernel.org, timur@...eaurora.org,
        cov@...eaurora.org, jcm@...hat.com, agross@...eaurora.org,
        linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Dan Williams <dan.j.williams@...el.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Dave Jiang <dave.jiang@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for
 tx_status

On 8/30/2016 1:04 PM, Vinod Koul wrote:
> On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote:
> 
>>  	spin_lock_init(&lldev->lock);
>> -	tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev);
> 
> ??
> 
> This is not described in changlog? If you are not using in anywhere else,
> then rst_task variable should be removed too..
> 

Sure, I can add more description. I thought I did mention that we are no longer
resetting the hardware in ISR. 

I can certainly mention that rst_task variable is removed and can get rid of it.
It is no longer in use.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.