linux-kernel - [PATCH 9/9] fs/nfsd/nfs4callback: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <832a8e0663b86e86c65dd3c49e049b8d43eff4cd.1472578959.git.bhaktipriya96@gmail.com>
Date:   Tue, 30 Aug 2016 23:17:21 +0530
From:   Bhaktipriya Shridhar <bhaktipriya96@...il.com>
To:     David Howells <dhowells@...hat.com>,
        Mark Fasheh <mfasheh@...e.com>,
        Joel Becker <jlbec@...lplan.org>,
        Michal Hocko <mhocko@...e.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Vladimir Davydov <vdavydov@...tuozzo.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Joseph Qi <joseph.qi@...wei.com>,
        "Norton.Zhu" <norton.zhu@...wei.com>,
        Jun Piao <piaojun@...wei.com>, xuejiufei <xuejiufei@...wei.com>
Cc:     ocfs2-devel@....oracle.com, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>
Subject: [PATCH 9/9] fs/nfsd/nfs4callback: Remove deprecated
 create_singlethread_workqueue

The workqueue "callback_wq" queues a single work item &cb->cb_work per
nfsd4_callback instance and thus, it doesn't require execution ordering.
Hence, alloc_workqueue has been used to replace the
deprecated create_singlethread_workqueue instance.

The WQ_MEM_RECLAIM flag has not been set since this is an in-kernel nfs
server and isn't involved in memory reclaim operations on the local
host.

Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
---
 fs/nfsd/nfs4callback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 7389cb1..a6611c6 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1021,7 +1021,7 @@ static const struct rpc_call_ops nfsd4_cb_ops = {

 int nfsd4_create_callback_queue(void)
 {
-	callback_wq = create_singlethread_workqueue("nfsd4_callbacks");
+	callback_wq = alloc_workqueue("nfsd4_callbacks", 0, 0);
 	if (!callback_wq)
 		return -ENOMEM;
 	return 0;
--
2.1.4