linux-kernel - Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFHUOYxi1=K9RSgxA0HLXH4Tq3iyCLMrYbyGmVowATwWc1KU_g@mail.gmail.com>
Date:   Tue, 30 Aug 2016 11:20:53 -0700
From:   Hoan Tran <hotran@....com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Prashanth Prakash <pprakash@...eaurora.org>,
        Ashwin Chaugule <ashwin.chaugule@...aro.org>
Cc:     linux acpi <linux-acpi@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, Loc Ho <lho@....com>,
        Duc Dang <dhdang@....com>, Hoan Tran <hotran@....com>,
        ashwinch@...gle.com
Subject: Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag

On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran <hotran@....com> wrote:
> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
> function to notify the mailbox framework about TX completion.
>
> Signed-off-by: Hoan Tran <hotran@....com>
> ---
> This patch is tested on top and depends on patch[1]:
> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
>  - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
>
>  drivers/acpi/cppc_acpi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 2e98173..19606aa 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd)
>                         last_cmd_cmpl_time = ktime_get();
>         }
>
> -       mbox_client_txdone(pcc_channel, ret);
> +       if (pcc_channel->mbox->txdone_irq)
> +               mbox_chan_txdone(pcc_channel, ret);
> +       else
> +               mbox_client_txdone(pcc_channel, ret);
> +
>         return ret;
>  }
>
> --
> 1.9.1
>

Any feedbacks.

Thanks
Hoan