linux-kernel - Re: [PATCH v2 6/8] pinctrl: Add pinctrl-aspeed-g4 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2016 15:34:08 +0930
From:   Joel Stanley <joel@....id.au>
To:     Andrew Jeffery <andrew@...id.au>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Jeremy Kerr <jk@...abs.org>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 6/8] pinctrl: Add pinctrl-aspeed-g4 driver

On Fri, Aug 19, 2016 at 10:14 PM, Andrew Jeffery <andrew@...id.au> wrote:
> A subset of the pins and functions are exposed. The selection of
> functions and pins is driven by the development of OpenBMC[1] on the
> AST2400 SoC, particularly around booting the OpenPOWER Palmetto
> development machine.

Looks good to me. I've given them a run on a few different machines.
You've addressed all of issues I had from v1.

>
> [1] https://github.com/openbmc/docs
>
> Signed-off-by: Andrew Jeffery <andrew@...id.au>

Reviewed-by: Joel Stanley <joel@....id.au>

> ---
>
> Since v1:
>
> * Fix the RMII1 signal descriptor bit
> * Add a number of new mux function and pin definitions
> * Sort the pin, group and function arrays for sanity
> * Add SoC-specific compatible string
>
>  drivers/pinctrl/aspeed/Kconfig             |    8 +
>  drivers/pinctrl/aspeed/Makefile            |    1 +
>  drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c | 1231 ++++++++++++++++++++++++++++
>  3 files changed, 1240 insertions(+)
>  create mode 100644 drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c