linux-kernel - Re: [PATCH v10 1/4] i2c: tegra: use readl_poll_timeout after config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160830203254.GC3645@katana>
Date:   Tue, 30 Aug 2016 22:32:55 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Shardar Shariff Md <smohammed@...dia.com>
Cc:     swarren@...dotorg.org, thierry.reding@...il.com, gnurou@...il.com,
        linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, jonathanh@...dia.com
Subject: Re: [PATCH v10 1/4] i2c: tegra: use readl_poll_timeout after
 config_load reg programmed

On Wed, Aug 31, 2016 at 12:41:16AM +0530, Shardar Shariff Md wrote:
> After CONFIG_LOAD register is programmed instead of explicitly waiting
> for timeout, use readl_poll_timeout() to check for register value to get
> updated or wait till timeout.
> 
> Signed-off-by: Shardar Shariff Md <smohammed@...dia.com>
> ---
> Changes in v4:
> - Split timeout calculation to separate patch
> 
> Changes in v5:
> - Move disabling of clock to separate patch
> 
> Changes in v8:
> - 1st change of [PATCH v7] series is merged, v8 is rebased on top of
>   merged change, here patch series is changed accordingly.
> - Updated the commit message as per review to properly reflect change.
> - calculate the register offset seperately to make code more readable.
> 
> Changes in v9:
> - Use readl_poll_timeout() instead of readx_poll_timeout()
> 
> Changes in V10:
> - Rebase on top of [PATCH V2 0/9] Some Tegra I2C Updates

Thanks for the rebase! However, my code checkers showed a few warnings:

    SPARSE
drivers/i2c/busses/i2c-tegra.c:504:21: warning: symbol 'val' shadows an earlier one
drivers/i2c/busses/i2c-tegra.c:451:13: originally declared here


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)