linux-kernel - Re: [PATCH v3 2/3] tracing: Add trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160830170626.653c9501@gandalf.local.home>
Date:   Tue, 30 Aug 2016 17:06:26 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Daniel Wagner <daniel.wagner@...-carit.de>
Cc:     Binoy Jayan <binoy.jayan@...aro.org>,
        Ingo Molnar <mingo@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        <linaro-kernel@...ts.linaro.org>, Carsten Emde <C.Emde@...dl.org>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        Masami <masami.hiramatsu@...aro.org>
Subject: Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints

On Tue, 30 Aug 2016 17:02:03 +0200
Daniel Wagner <daniel.wagner@...-carit.de> wrote:

> On 08/30/2016 04:20 PM, Daniel Wagner wrote:
> > Just setting the size of the type is not enough. The hist_field_* 
> > getter function want to know the offset too:  
> 
> With this hack here it should work. The COMM generic field is handled via
> the tracing_map_ops. We could do it also there but than we need to 
> a condition in the trace_map_ops if it is COMM or CPU. 
> This shortcut here avoids it:
> 

I think the tracing_map_ops is the proper fix. I'd like to keep comm
and cpu identical, as they are both basically "meta fields".

-- Steve