linux-kernel - Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160830171506.1b970ff0@gandalf.local.home>
Date:   Tue, 30 Aug 2016 17:15:06 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     Dmitry Safonov <dsafonov@...tuozzo.com>,
        linux-kernel@...r.kernel.org, mingo@...hat.com,
        luto@...capital.net, tglx@...utronix.de, hpa@...or.com,
        x86@...nel.org, 0x7f454c46@...il.com, viro@...iv.linux.org.uk
Subject: Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe

On Tue, 30 Aug 2016 16:37:28 +0200
Oleg Nesterov <oleg@...hat.com> wrote:

> On 08/29, Steven Rostedt wrote:
> >
> > On Mon, 29 Aug 2016 18:58:13 -0400
> > Steven Rostedt <rostedt@...dmis.org> wrote:
> >  
> > > On Thu, 25 Aug 2016 18:21:09 +0300
> > > Dmitry Safonov <dsafonov@...tuozzo.com> wrote:
> > >  
> > > > It's useless. Before:
> > > >   [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> > > >   [tracing]# echo 'p:test a:0x0' >> uprobe_events
> > > >   -bash: echo: write error: No such file or directory
> > > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > > >   -bash: echo: write error: Invalid argument
> > > > 
> > > > After:
> > > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > > >   -bash: echo: write error: No such file or directory
> > > > 
> > > > Signed-off-by: Dmitry Safonov <dsafonov@...tuozzo.com>    
> > > 
> > > Acked-by: Steven Rostedt <rostedt@...dmis.org>  
> >
> > Actually, this patch seems agnostic to the series. I'll just pull it in
> > now.  
> 
> Yes, agreed, this isdigit() is pointless, thanks.

Should I put you down as an Acked-by?

-- Steve