linux-kernel - Re: [PATCH] irda: Fix likely typo in output format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160831.145210.1717182207800099854.davem@davemloft.net>
Date:   Wed, 31 Aug 2016 14:52:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     green@...uxhacker.ru
Cc:     samuel@...tiz.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irda: Fix likely typo in output format string

From: Oleg Drokin <green@...uxhacker.ru>
Date: Wed, 31 Aug 2016 17:36:44 -0400

> 
> On Aug 31, 2016, at 5:31 PM, David Miller wrote:
> 
>> From: Oleg Drokin <green@...uxhacker.ru>
>> Date: Fri, 26 Aug 2016 23:14:06 -0400
>> 
>>> %ul would print an unsigned with a letter l at the end which does
>>> not seem to be desired here, on the other hand the value being printed
>>> is u32 so just drop the l instead of converting to %lu
>>> 
>>> Signed-off-by: Oleg Drokin <green@...uxhacker.ru>
>> 
>> %u is for unsigned values, and these are "s32" thus signed.
> 
> Hm, you are right.
> I could swear I saw them as unsigned when I looked at it.
> 
> Anyway can they really be negative? they are seconds and usec,
> should I change them to u32 too?

If you're interesting in continuing with this, it is your
area for exploration not our's :-)