linux-kernel - Re: [RESEND PATCH v2] memory-hotplug: fix store_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160831233811.g6kf24fdhnfhn637@arbab-vm>
Date:   Wed, 31 Aug 2016 18:38:12 -0500
From:   Reza Arbab <arbab@...ux.vnet.ibm.com>
To:     David Rientjes <rientjes@...gle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Yaowei Bai <baiyaowei@...s.chinamobile.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Dan Williams <dan.j.williams@...el.com>,
        Xishi Qiu <qiuxishi@...wei.com>,
        David Vrabel <david.vrabel@...rix.com>,
        Chen Yucong <slaoub@...il.com>,
        Andrew Banman <abanman@....com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return
 value

On Wed, Aug 31, 2016 at 02:06:14PM -0700, David Rientjes wrote:
>The correct fix is for store_mem_state() to return -EINVAL when 
>device_online() returns non-zero.

Let me put it to you this way--which one of these sysfs operations is 
behaving correctly?

	# cd /sys/devices/system/memory/memory0
	# cat online
	1
	# echo 1 > online; echo $?
	0

or

	# cd /sys/devices/system/memory/memory0
	# cat state
	online
	# echo online > state; echo $?
	-bash: echo: write error: Invalid argument
	1

One of them should change to match the other.

-- 
Reza Arbab