linux-kernel - Re: [PATCH] mfd: arizona: Add sensible return value to some error paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2016 10:13:05 +0100
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     <linux-kernel@...r.kernel.org>,
        <patches@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH] mfd: arizona: Add sensible return value to some error
 paths

On Wed, Aug 31, 2016 at 09:43:27AM +0100, Lee Jones wrote:
> On Fri, 12 Aug 2016, Charles Keepax wrote:
> 
> > There are some cases in arizona_dev_init, such as where we don't
> > recognise the chip ID, in which we head to the error path without
> > setting a sensible error code in ret. This would lead to the chip
> > silently failing probe, as it would still return 0. Fix this up by
> > adding appropriate sets of the return value.
> > 
> > Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> > ---
> >  drivers/mfd/arizona-core.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> > index e4f97b3..34a2c26 100644
> > --- a/drivers/mfd/arizona-core.c
> > +++ b/drivers/mfd/arizona-core.c
> > @@ -1121,6 +1121,7 @@ int arizona_dev_init(struct arizona *arizona)
> >  		break;
> >  	default:
> >  		dev_err(arizona->dev, "Unknown device ID: %x\n", reg);
> > +		ret = -EINVAL;
> 
> -EINVAL doesn't seem right here.
> 
> -ENODEV perhaps?
> 

Yeah that does seem better, I will fire out another version.

Thanks,
Charles