linux-kernel - Re: [PATCH 1/2] mfd: mc13xxx: constify mc13xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160831092054.GC27357@dell>
Date:   Wed, 31 Aug 2016 10:20:54 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     LABBE Corentin <clabbe.montjoie@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: mc13xxx: constify mc13xxx_variant

On Tue, 16 Aug 2016, LABBE Corentin wrote:

> The mc13xxx_variant structure is never modified, this patch set it as
> const.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>

Any chance you can uncapitalise your whole name?

> ---
>  drivers/mfd/mc13xxx-core.c | 6 +++---
>  drivers/mfd/mc13xxx-i2c.c  | 2 +-
>  drivers/mfd/mc13xxx-spi.c  | 2 +-
>  drivers/mfd/mc13xxx.h      | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
> index d7f54e4..3a008e6 100644
> --- a/drivers/mfd/mc13xxx-core.c
> +++ b/drivers/mfd/mc13xxx-core.c
> @@ -202,19 +202,19 @@ static void mc34708_print_revision(struct mc13xxx *mc13xxx, u32 revision)
>  }
>  
>  /* These are only exported for mc13xxx-i2c and mc13xxx-spi */
> -struct mc13xxx_variant mc13xxx_variant_mc13783 = {
> +const struct mc13xxx_variant mc13xxx_variant_mc13783 = {
>  	.name = "mc13783",
>  	.print_revision = mc13xxx_print_revision,
>  };
>  EXPORT_SYMBOL_GPL(mc13xxx_variant_mc13783);
>  
> -struct mc13xxx_variant mc13xxx_variant_mc13892 = {
> +const struct mc13xxx_variant mc13xxx_variant_mc13892 = {
>  	.name = "mc13892",
>  	.print_revision = mc13xxx_print_revision,
>  };
>  EXPORT_SYMBOL_GPL(mc13xxx_variant_mc13892);
>  
> -struct mc13xxx_variant mc13xxx_variant_mc34708 = {
> +const struct mc13xxx_variant mc13xxx_variant_mc34708 = {
>  	.name = "mc34708",
>  	.print_revision = mc34708_print_revision,
>  };
> diff --git a/drivers/mfd/mc13xxx-i2c.c b/drivers/mfd/mc13xxx-i2c.c
> index 67e4c9a..3c00ccb 100644
> --- a/drivers/mfd/mc13xxx-i2c.c
> +++ b/drivers/mfd/mc13xxx-i2c.c
> @@ -82,7 +82,7 @@ static int mc13xxx_i2c_probe(struct i2c_client *client,
>  			of_match_device(mc13xxx_dt_ids, &client->dev);
>  		mc13xxx->variant = of_id->data;
>  	} else {
> -		mc13xxx->variant = (void *)id->driver_data;
> +		mc13xxx->variant = (const struct mc13xxx_variant *)id->driver_data;

Is this change required?

>  	}
>  
>  	return mc13xxx_common_init(&client->dev);
> diff --git a/drivers/mfd/mc13xxx-spi.c b/drivers/mfd/mc13xxx-spi.c
> index cbc1e5e..6100025 100644
> --- a/drivers/mfd/mc13xxx-spi.c
> +++ b/drivers/mfd/mc13xxx-spi.c
> @@ -162,7 +162,7 @@ static int mc13xxx_spi_probe(struct spi_device *spi)
>  	} else {
>  		const struct spi_device_id *id_entry = spi_get_device_id(spi);
>  
> -		mc13xxx->variant = (void *)id_entry->driver_data;
> +		mc13xxx->variant = (const struct mc13xxx_variant *)id_entry->driver_data;

Same here?

>  	}
>  
>  	return mc13xxx_common_init(&spi->dev);
> diff --git a/drivers/mfd/mc13xxx.h b/drivers/mfd/mc13xxx.h
> index 33677d1..6d7fce5 100644
> --- a/drivers/mfd/mc13xxx.h
> +++ b/drivers/mfd/mc13xxx.h
> @@ -24,7 +24,7 @@ struct mc13xxx_variant {
>  	void (*print_revision)(struct mc13xxx *mc13xxx, u32 revision);
>  };
>  
> -extern struct mc13xxx_variant
> +extern const struct mc13xxx_variant
>  		mc13xxx_variant_mc13783,
>  		mc13xxx_variant_mc13892,
>  		mc13xxx_variant_mc34708;

I haven't seen this formatting before.

Can you take the opportunity to write these out separately?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog