linux-kernel - Re: [PATCH V7 5/5] perf tools: adding sink configuration for cs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94a6e940-cce8-a179-fe0c-c69a543e302c@arm.com>
Date:   Wed, 31 Aug 2016 10:37:43 +0100
From:   Suzuki K Poulose <Suzuki.Poulose@....com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>, acme@...nel.org
Cc:     acme@...radead.org, peterz@...radead.org, jolsa@...nel.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V7 5/5] perf tools: adding sink configuration for cs_etm
 PMU

On 30/08/16 17:19, Mathieu Poirier wrote:
> Using the PMU::set_drv_config() callback to enable the CoreSight
> sink that will be used for the trace session.

> +int cs_etm_set_drv_config(struct perf_evsel_config_term *term)
> +{
> +	int ret;
> +	char enable_sink[ENABLE_SINK_MAX];
> +
> +	snprintf(enable_sink, ENABLE_SINK_MAX, "%s/%s",
> +		 term->val.drv_cfg, "enable_sink");
> +
> +	ret = cs_device__print_file(enable_sink, "%d", 1);
> +	if (ret < 0)
> +		return ret;
> +
> +	return 0;
> +}


Don't we have to disable the sink at the end of the session ? How is that
taken care of ? Did I miss that ?

Suzuki