linux-kernel - Re: [PATCH] phy: mark tegra_xusb_lane_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7060924.RuInUXIHDe@wuerfel>
Date:   Wed, 31 Aug 2016 12:01:11 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     kishon@...com, swarren@...dotorg.org, thierry.reding@...il.com,
        gnurou@...il.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, xie.baoyou@....com.cn
Subject: Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static

On Wednesday, August 31, 2016 5:05:19 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/phy/tegra/xusb.c:104:5: warning: no previous prototype for 'tegra_xusb_lane_lookup_function' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> 

Acked-by: Arnd Bergmann <arnd@...db.de>

Same comment as for the other patch, it's better to use "phy: tegra: ..."
in the subject for clarity.

	Arnd