linux-kernel - Re: [PATCH] Input: focaltech - mark focaltech_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5089277.G6NWohFGP5@wuerfel>
Date:   Wed, 31 Aug 2016 11:58:50 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     dmitry.torokhov@...il.com, pali.rohar@...il.com,
        hdegoede@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, xie.baoyou@....com.cn
Subject: Re: [PATCH] Input: focaltech - mark focaltech_set_resolution() static

On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> 

Acked-by: Arnd Bergmann <arnd@...db.de>