linux-kernel - Re: [PATCH] phy: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5510665.v78tdpezgV@wuerfel>
Date:   Wed, 31 Aug 2016 12:00:01 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     kishon@...com, swarren@...dotorg.org, thierry.reding@...il.com,
        gnurou@...il.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, xie.baoyou@....com.cn
Subject: Re: [PATCH] phy: add missing header dependencies

On Wednesday, August 31, 2016 4:56:49 PM CEST Baoyou Xie wrote:
> We get 5 warnings when building kernel with W=1:
> drivers/phy/tegra/xusb.c:948:27: warning: no previous prototype for 'tegra_xusb_padctl_get' [-Wmissing-prototypes]
> drivers/phy/tegra/xusb.c:981:6: warning: no previous prototype for 'tegra_xusb_padctl_put' [-Wmissing-prototypes]
> drivers/phy/tegra/xusb.c:988:5: warning: no previous prototype for 'tegra_xusb_padctl_usb3_save_context' [-Wmissing-prototypes]
> drivers/phy/tegra/xusb.c:998:5: warning: no previous prototype for 'tegra_xusb_padctl_hsic_set_idle' [-Wmissing-prototypes]
> drivers/phy/tegra/xusb.c:1008:5: warning: no previous prototype for 'tegra_xusb_padctl_usb3_set_lfps_detect' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in linux/phy/tegra/xusb.h,
> so this patch adds missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Patch looks good

Acked-by: Arnd Bergmann <arnd@...db.de>

In the subject line, this time being more specific is better (there
are many distinct phy drivers), so use "phy: tegra: ..." here.

	Arnd