linux-kernel - Re: [PATCH v8 1/3] mfd: lp873x: Add lp873x PMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160831111604.GG27357@dell>
Date:   Wed, 31 Aug 2016 12:16:04 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Keerthy <a0393675@...com>
Cc:     Keerthy <j-keerthy@...com>, broonie@...nel.org,
        linus.walleij@...aro.org, linux-omap@...r.kernel.org,
        robh+dt@...nel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 1/3] mfd: lp873x: Add lp873x PMIC support

On Wed, 31 Aug 2016, Keerthy wrote:
> On Wednesday 31 August 2016 01:26 PM, Lee Jones wrote:
> > On Fri, 12 Aug 2016, Keerthy wrote:
> > 
> > > The LP873X chip is a power management IC for Portable Navigation Systems
> > >     and Tablet Computing devices. It contains the following components:
> > > 
> > >      - Regulators.
> > >      - Configurable General Purpose Output Signals(GPO).

[...]

> > > +static const struct i2c_device_id lp873x_id_table[] = {
> > > +	{ "lp873x", LP873X },
> > > +	{ },
> > > +};
> > > +MODULE_DEVICE_TABLE(i2c, lp873x_id_table);
> > 
> > Don't set the ID in this table.
> 
> I did not understand this. Could you please elaborate?
> You mean no need of LP873X can just be a '0' as i am seeing in other mfd
> drivers?

Just leave it blank.  No need for the second attribute.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog