linux-kernel - drm/atmel-hlcdc: connector type & fbdev mode settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <61FA15C5AEE1ED4E827ADEB50820C1443EB181948F@MAIL03.corp.lgcns.com>
Date:   Wed, 31 Aug 2016 11:29:53 +0900
From:   Hyung Jin Jung <realbright@...ns.com>
To:     "boris.brezillon@...e-electrons.com" 
        <boris.brezillon@...e-electrons.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: drm/atmel-hlcdc: connector type & fbdev mode settings

According to Atmel's guideline... http://www.at91.com/linux4sam/bin/view/Linux4SAM/UsingAtmelDRMDriver

the "fbdev emulation mode" could be set from kernel command line (LVDS-1:...)
however, driver register it as DRM_MODE_CONNECTOR_Unknown connector.

Actually we using sama5d3x with LVDS cable so that below patch would be correct.
But I don't know the other case such as HDMI, composite... 

Do we need to consider using DT or auto-detection??

Signed-off-by: HyungJin Jung <realbright@...ns.com>
---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
index 6119b50..da97efe
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
@@ -208,7 +208,7 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev,
 				&atmel_hlcdc_panel_connector_helper_funcs);
 		ret = drm_connector_init(dev, &output->connector,
 					 &atmel_hlcdc_panel_connector_funcs,
-					 DRM_MODE_CONNECTOR_Unknown);
+					 DRM_MODE_CONNECTOR_LVDS);
 		if (ret)
 			goto err_encoder_cleanup;
 
-- 
1.9.1

BR,
Davy