linux-kernel - Re: [PATCH v4 2/3] tracing: Add trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHv-k_-bmqw0hqcO1m7gL-vt4xntqUStXm=+7ymYj1Rhp-KYrw@mail.gmail.com>
Date:   Wed, 31 Aug 2016 17:09:20 +0530
From:   Binoy Jayan <binoy.jayan@...aro.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Daniel Wagner <daniel.wagner@...-carit.de>,
        Arnd Bergmann <arnd@...db.de>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        Masami <masami.hiramatsu@...aro.org>
Subject: Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints

Hi Steven/Daniel,

On 30 August 2016 at 19:38, Steven Rostedt <rostedt@...dmis.org> wrote:
>> +
>> +     TP_printk("ltype=%d, latency=%lu",
>> +             __entry->ltype, (unsigned long) __entry->latency)
>
> The print of ltype should be text and not a number. Well, you could
> have both text and a number, but a number is useless for those looking
> at traces.

I am using '__print_symbolic' to display ltype as a string but it
still shows up in
the histogram as a number. Would you suggest to change this as well?

Thanks,
Binoy