linux-kernel - Re: [PATCH v2 3/4] arm64: dts: rockchip: add clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2221946-fbaf-ef86-c673-67c07e456053@rock-chips.com>
Date:   Wed, 31 Aug 2016 11:19:35 +0800
From:   Ziyuan Xu <xzy.xu@...k-chips.com>
To:     Shawn Lin <shawn.lin@...k-chips.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Rob Herring <robh+dt@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 3/4] arm64: dts: rockchip: add clk_syscon for sdhci on
 rk3399

Hi Shawn,


On 2016年08月31日 09:37, Shawn Lin wrote:
> We are intent on letting the sdhci variant driver handle this
> optional clock on rk3399 platform now.
>
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> ---

Thanks for your patch, we can gate aclk_emmcgrf now as soon as sdhci 
driver suspend.

Reviewed-by: Ziyuan Xu <xzy.xu@...k-chips.com>
Tested-by: Ziyuan Xu <xzy.xu@...k-chips.com>

>
> Changes in v2: None
>
>   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index bc86e8c..d26c6ad 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -233,8 +233,9 @@
>   		arasan,soc-ctl-syscon = <&grf>;
>   		assigned-clocks = <&cru SCLK_EMMC>;
>   		assigned-clock-rates = <200000000>;
> -		clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>;
> -		clock-names = "clk_xin", "clk_ahb";
> +		clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>,
> +			 <&cru ACLK_EMMC_GRF>;
> +		clock-names = "clk_xin", "clk_ahb", "clk_syscon";
>   		clock-output-names = "emmc_cardclock";
>   		#clock-cells = <0>;
>   		phys = <&emmc_phy>;