linux-kernel - Re: [PATCH 4/9] fs/afs/flock: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160831142840.GQ12660@htj.duckdns.org>
Date:   Wed, 31 Aug 2016 10:28:40 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:     David Howells <dhowells@...hat.com>,
        Mark Fasheh <mfasheh@...e.com>,
        Joel Becker <jlbec@...lplan.org>,
        Michal Hocko <mhocko@...e.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Vladimir Davydov <vdavydov@...tuozzo.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Joseph Qi <joseph.qi@...wei.com>,
        "Norton.Zhu" <norton.zhu@...wei.com>,
        Jun Piao <piaojun@...wei.com>,
        xuejiufei <xuejiufei@...wei.com>, ocfs2-devel@....oracle.com,
        linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] fs/afs/flock: Remove deprecated
 create_singlethread_workqueue

On Tue, Aug 30, 2016 at 11:15:28PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "afs_lock_manager" queues a single work item
> &vnode->lock_work, and hence it doesn't require execution ordering.
> Hence, alloc_workqueue has been used to replace the deprecated
> create_singlethread_workqueue instance.
> 
> The WQ_MEM_RECLAIM flag has been set to ensure forward progress under
> memory pressure because the workqueue is being used on a memory reclaim
> path.
> 
> Since there are fixed number of work items, explicit concurrency
> limit is unnecessary here.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>

For all afs patches,

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun