linux-kernel - Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in JSON format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160831145459.GA32396@krava>
Date:   Wed, 31 Aug 2016 16:54:59 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>, mingo@...hat.com,
        Michael Ellerman <mpe@...erman.id.au>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        peterz@...radead.org, maddy@...ux.vnet.ibm.com,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in
 JSON format

On Wed, Aug 31, 2016 at 07:42:47AM -0700, Andi Kleen wrote:
> > hi,
> > I had discussion with Ingo about the state of this patchset
> > and there's one more requirement from his side - to split
> > event files into per topic files
> 
> Thanks Jiri.
> > 
> > I made some initial changes over latest Sukadev's branch
> > and came up with something like this:
> 
> Did you just split it by the "Topic" fields?

yep

> 
> > 
> > 	$ find pmu-events/arch/x86/
> > 	pmu-events/arch/x86/
> > 	pmu-events/arch/x86/NehalemEX_core
> > 	pmu-events/arch/x86/NehalemEX_core/Memory.json
> > 	pmu-events/arch/x86/NehalemEX_core/Virtual-Memory.json
> > 	pmu-events/arch/x86/NehalemEX_core/Cache.json
> > 	pmu-events/arch/x86/NehalemEX_core/Pipeline.json
> > 	pmu-events/arch/x86/NehalemEX_core/Floating-point.json
> > 	pmu-events/arch/x86/NehalemEX_core/Other.json
> > 	pmu-events/arch/x86/mapfile.csv
> > 	pmu-events/arch/x86/Broadwell_core
> > 	pmu-events/arch/x86/Broadwell_core/Memory.json
> > 	pmu-events/arch/x86/Broadwell_core/Virtual-Memory.json
> > 	pmu-events/arch/x86/Broadwell_core/Cache.json
> > 	pmu-events/arch/x86/Broadwell_core/Pipeline.json
> > 	pmu-events/arch/x86/Broadwell_core/Floating-point.json
> > 	pmu-events/arch/x86/Broadwell_core/Other.json
> > 	pmu-events/arch/x86/Broadwell_core/Frontend.json
> > 
> > so let's have a discussion if this is acceptable for you guys
> 
> Splitting is fine for me, as long as it's scriptable.
> 
> I already have some scripts to generate the perf json files,
> can update them to split.

yep, there's split-json.py script earlier in the perf/json branch

> 
> > 
> > I've already made some changes in pmu-events/* to support
> > this hierarchy to see how bad the change would be.. and
> > it's not that bad ;-)
> 
> Everything has to be automated, please no manual changes.

sure

so, if you're ok with the layout, how do you want to proceed further?

thanks,
jirka