linux-kernel - [PATCH] Input: joystick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2016 21:04:22 +0530
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: [PATCH] Input: joystick - enable interrupts

The irq was disabled before reading from the gameport. After reading
we should enable it. Instead we were restoring it back to the previous
state before starting the do-while loop.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
---
 drivers/input/joystick/analog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/joystick/analog.c b/drivers/input/joystick/analog.c
index 3d8ff09..faa90bc 100644
--- a/drivers/input/joystick/analog.c
+++ b/drivers/input/joystick/analog.c
@@ -275,7 +275,7 @@ static int analog_cooked_read(struct analog_port *port)
 		local_irq_disable();
 		this = gameport_read(gameport) & port->mask;
 		now = get_time();
-		local_irq_restore(flags);
+		local_irq_enable();
 
 		if ((last ^ this) && (delta(loop, now) < loopout)) {
 			data[i] = last ^ this;
-- 
1.9.1