linux-kernel - Re: [PATCH] rtc: changed raw spi calls to register map calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2016 22:21:18 +0530
From:   Raghavendra Chandra Ganiga <ravi23ganiga@...il.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
        a.zummo@...ertech.it
Subject: Re: [PATCH] rtc: changed raw spi calls to register map calls



On Wednesday 31 August 2016 03:18 AM, Alexandre Belloni wrote:
> Hi,
> 
> Please fix the subject, this patch is ds1347 specific.
> 
Yes I will fix the subject

> On 31/08/2016 at 01:28:33 +0530, RAGHAVENDRA GANIGA wrote :
>> From 2ec82b6c9b99647e31d26c4c828dc7c51af8a633 Mon Sep 17 00:00:00 2001
>> From: Raghavendra Ganiga <ravi23ganiga@...il.com>
>> Date: Wed, 31 Aug 2016 01:13:30 +0530
>> Subject: [PATCH] rtc: changed raw spi calls to register map calls
>>
>> This patch changes calls of spi read write calls to register map
>> read and write calls
>>
> 
> Can you explain why you need that change? I'm not sure what you gain
> from it (it makes the driver and the kernel bigger).
> 
Regmaps abstract layer are a better way of accessing register through 
spi interface rather than accessing directly through SPI layer

>>  	/* year in linux is from 1900 i.e in range of 100
>> -	in rtc it is from 00 to 99 */
>> +	 * in rtc it is from 00 to 99
>> +	 */
> 
> Unrelated change.
> 
> 
will have a seperate patch for this checkpatch.pl fix