| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Aug 2016 22:48:29 +0530
From: Mani Sadhasivam <manivannanece23@...il.com>
To: gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH] Staging: rtl8712: Prefer ether_addr_copy
This patch fixes the checkpatch.pl warning to prefer
ether_addr_copy over memcpy
Signed-off-by: Mani Sadhasivam <manivannanece23@...il.com>
---
drivers/staging/rtl8712/rtl871x_recv.c | 44 +++++++++++++++++-----------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_recv.c b/drivers/staging/rtl8712/rtl871x_recv.c
index 23c1438..63409d0 100644
--- a/drivers/staging/rtl8712/rtl871x_recv.c
+++ b/drivers/staging/rtl8712/rtl871x_recv.c
@@ -352,11 +352,11 @@ static sint sta2sta_data_frame(struct _adapter *adapter,
sta_addr = pattrib->src;
}
} else if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) {
- memcpy(pattrib->dst, GetAddr1Ptr(ptr), ETH_ALEN);
- memcpy(pattrib->src, GetAddr2Ptr(ptr), ETH_ALEN);
- memcpy(pattrib->bssid, GetAddr3Ptr(ptr), ETH_ALEN);
- memcpy(pattrib->ra, pattrib->dst, ETH_ALEN);
- memcpy(pattrib->ta, pattrib->src, ETH_ALEN);
+ ether_addr_copy(pattrib->dst, GetAddr1Ptr(ptr));
+ ether_addr_copy(pattrib->src, GetAddr2Ptr(ptr));
+ ether_addr_copy(pattrib->bssid, GetAddr3Ptr(ptr));
+ ether_addr_copy(pattrib->ra, pattrib->dst);
+ ether_addr_copy(pattrib->ta, pattrib->src);
sta_addr = mybssid;
} else {
ret = _FAIL;
@@ -418,12 +418,12 @@ static sint ap2sta_data_frame(struct _adapter *adapter,
return _FAIL;
} else if (check_fwstate(pmlmepriv, WIFI_MP_STATE) &&
check_fwstate(pmlmepriv, _FW_LINKED)) {
- memcpy(pattrib->dst, GetAddr1Ptr(ptr), ETH_ALEN);
- memcpy(pattrib->src, GetAddr2Ptr(ptr), ETH_ALEN);
- memcpy(pattrib->bssid, GetAddr3Ptr(ptr), ETH_ALEN);
- memcpy(pattrib->ra, pattrib->dst, ETH_ALEN);
- memcpy(pattrib->ta, pattrib->src, ETH_ALEN);
- memcpy(pattrib->bssid, mybssid, ETH_ALEN);
+ ether_addr_copy(pattrib->dst, GetAddr1Ptr(ptr));
+ ether_addr_copy(pattrib->src, GetAddr2Ptr(ptr));
+ ether_addr_copy(pattrib->bssid, GetAddr3Ptr(ptr));
+ ether_addr_copy(pattrib->ra, pattrib->dst);
+ ether_addr_copy(pattrib->ta, pattrib->src);
+ ether_addr_copy(pattrib->bssid, mybssid);
*psta = r8712_get_stainfo(pstapriv, pattrib->bssid);
if (*psta == NULL)
return _FAIL;
@@ -485,28 +485,28 @@ static sint validate_recv_data_frame(struct _adapter *adapter,
pbssid = get_hdr_bssid(ptr);
if (pbssid == NULL)
return _FAIL;
- memcpy(pattrib->dst, pda, ETH_ALEN);
- memcpy(pattrib->src, psa, ETH_ALEN);
- memcpy(pattrib->bssid, pbssid, ETH_ALEN);
+ ether_addr_copy(pattrib->dst, pda);
+ ether_addr_copy(pattrib->src, psa);
+ ether_addr_copy(pattrib->bssid, pbssid);
switch (pattrib->to_fr_ds) {
case 0:
- memcpy(pattrib->ra, pda, ETH_ALEN);
- memcpy(pattrib->ta, psa, ETH_ALEN);
+ ether_addr_copy(pattrib->ra, pda);
+ ether_addr_copy(pattrib->ta, psa);
res = sta2sta_data_frame(adapter, precv_frame, &psta);
break;
case 1:
- memcpy(pattrib->ra, pda, ETH_ALEN);
- memcpy(pattrib->ta, pbssid, ETH_ALEN);
+ ether_addr_copy(pattrib->ra, pda);
+ ether_addr_copy(pattrib->ta, pbssid);
res = ap2sta_data_frame(adapter, precv_frame, &psta);
break;
case 2:
- memcpy(pattrib->ra, pbssid, ETH_ALEN);
- memcpy(pattrib->ta, psa, ETH_ALEN);
+ ether_addr_copy(pattrib->ra, pbssid);
+ ether_addr_copy(pattrib->ta, psa);
res = sta2ap_data_frame(adapter, precv_frame, &psta);
break;
case 3:
- memcpy(pattrib->ra, GetAddr1Ptr(ptr), ETH_ALEN);
- memcpy(pattrib->ta, GetAddr2Ptr(ptr), ETH_ALEN);
+ ether_addr_copy(pattrib->ra, GetAddr1Ptr(ptr));
+ ether_addr_copy(pattrib->ta, GetAddr2Ptr(ptr));
return _FAIL;
default:
return _FAIL;
--
2.7.4
Powered by blists - more mailing lists