lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Aug 2016 21:14:50 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: fgao@...ai8.com Cc: davem@...emloft.net, philipp@...fish-solutions.com, tom@...bertland.com, aduyck@...antis.com, amir@...ai.me, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, gfree.wind@...il.com Subject: Re: [PATCH net] rps: flow_dissector: Fix uninitialized flow_keys used in __skb_get_hash possibly On Wed, 2016-08-31 at 10:56 +0800, fgao@...ai8.com wrote: > From: Gao Feng <fgao@...ai8.com> > > The original codes depend on that the function parameters are evaluated from > left to right. But the parameter's evaluation order is not defined in C > standard actually. > > When flow_keys_have_l4(&keys) is invoked before ___skb_get_hash(skb, &keys, > hashrnd) with some compilers or environment, the keys passed to > flow_keys_have_l4 is not initialized. > > Signed-off-by: Gao Feng <fgao@...ai8.com> > --- Good catch, please add Fixes: 6db61d79c1e1 ("flow_dissector: Ignore flow dissector return value from ___skb_get_hash") Acked-by: Eric Dumazet <edumazet@...gle.com>
Powered by blists - more mailing lists