linux-kernel - Re: [PATCH v3 0/5] net/usb: asix driver improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2016 13:28:34 -0400
From:   Robert Foss <robert.foss@...labora.com>
To:     freddy@...x.com.tw, Dean_Jenkins@...tor.com,
        Mark_Craske@...tor.com, davem@...emloft.net, ivecera@...hat.com,
        john.stultz@...aro.org, vpalatin@...omium.org,
        stephen@...workplumber.org, grundler@...omium.org,
        changchias@...il.com, allan@...x.com.tw, andrew@...n.ch,
        tremyfr@...il.com, colin.king@...onical.com,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, vpalatin@...gle.com
Subject: Re: [PATCH v3 0/5] net/usb: asix driver improvements

Additional testing has been done the hardware that is available to me.
I'm not seeing any dmesg warnings/errors that are new to this series:

AX88772A
- Pass network_EthernetStressPlug
- Pass phy up/down + iperf3 UDP stress
- Pass network_EthernetStressPlug + iperf3 UDP stress

AX88772B
- Pass network_EthernetStressPlug
- Pass phy up/down + iperf3 UDP stress
- Pass network_EthernetStressPlug + iperf3 UDP stress

Cisco AX88772 A(?)
- Pass network_EthernetStressPlug
- Pass phy up/down + iperf3 UDP stress
- Pass network_EthernetStressPlug + iperf3 UDP stress

Cisco AX88772 B(?)
- Pass network_EthernetStressPlug
- Pass phy up/down + iperf3 UDP stress
- Pass network_EthernetStressPlug + iperf3 UDP stress

AX88178
- Pass network_EthernetStressPlug
- Pass phy up/down + iperf3 UDP stress
- Pass network_EthernetStressPlug + iperf3 UDP stress

AX88179
- Pass network_EthernetStressPlug
- Pass phy up/down + iperf3 UDP stress?
-- [ 8794.555902] ax88179_178a 1-1.3:1.0 eth1: kevent 4 may have been
    dropped
- Pass network_EthernetStressPlug + iperf3 UDP stresss


I also saw some sporadic header checksum errors.
But those too are seen on upstream/master.

asix_rx_fixup() Bad Header Length 0x98a993c8, offset 4


Test details:
network_EthernetStressPlug:
     http://memcpy.io/ethernet-device-stress-testing.html

phy up/down:
     for i in
         {1..10}
     do
         sudo ifdown eth1
         if sudo ifup eth1; then
            echo "Command success"
        else
            echo "Command failed"
        fi
     done

iperf3 UDP:
     sudo iperf3 -c 192.168.0.28 -u  -b 100M -t 0





On 2016-08-29 09:32 AM, robert.foss@...labora.com wrote:
> From: Robert Foss <robert.foss@...labora.com>
>
> This is a resubmission of v3, since the netdev
> mailinlist was not sent the previous submission.
>
> This series improves power management of the asix driver.
>
>  - Suspend/resume support is improved to save needed registers.
>  - Device disconnection is improved.
>  - Fixes AX88772x resume failures
>  - Implementes IEEE 802.3 spec section "22.2.4.1.1 Reset" correctly
>  - Fixes AX_CMD_WRITE_MEDIUM_MODE being set incorrectly
>
> Changes since v1:
> - Added proper metadata tags to series.
> - Added two more patches to series.
>
> Changes since v2:
> - Added coverletter
> - Tested patches on AX88772A/AX88772B/AX88178/AX88179 hardware
>
> Allan Chou (1):
>   net: asix: Fix AX88772x resume failures
>
> Freddy Xin (1):
>   net: asix: Add in_pm parameter
>
> Grant Grundler (2):
>   net: asix: see 802.3 spec for phy reset
>   net: asix: autoneg will set WRITE_MEDIUM reg
>
> Vincent Palatin (1):
>   net: asix: Avoid looping when the device is disconnected
>
>  drivers/net/usb/asix.h         |  40 ++-
>  drivers/net/usb/asix_common.c  | 212 ++++++++++++----
>  drivers/net/usb/asix_devices.c | 450 +++++++++++++++++++++++++++-------
>  drivers/net/usb/ax88172a.c     |  29 +-
>  4 files changed, 575 insertions(+), 156 deletions(-)
>