linux-kernel - Re: [PATCH] PCI: Mark Haswell Power Control Unit as having non-compliant BARs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160831175543.GD16426@localhost>
Date:   Wed, 31 Aug 2016 12:55:43 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Prarit Bhargava <prarit@...hat.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Andi Kleen <ak@...ux.intel.com>,
        Myron Stowe <myron.stowe@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: Mark Haswell Power Control Unit as having
 non-compliant BARs

On Wed, Aug 31, 2016 at 01:42:13PM -0400, Prarit Bhargava wrote:
> On 08/31/2016 11:50 AM, Bjorn Helgaas wrote:
> > The Haswell Power Control Unit has a non-PCI register (CONFIG_TDP_NOMINAL)
> > where BAR 0 is supposed to be.  This is erratum HSE43 in the spec update
> > referenced below:
> > 
> >   The PCIe* Base Specification indicates that Configuration Space Headers
> >   have a base address register at offset 0x10.  Due to this erratum, the
> >   Power Control Unit's CONFIG_TDP_NOMINAL CSR (Bus 1; Device 30; Function
> >   3; Offset 0x10) is located where a base register is expected.
> > 
> > Mark the PCU as having non-compliant BARs so we don't try to probe any of
> > them.  There are no other BARs on this device.
> > 
> > Rename the quirk so it's not Broadwell-specific.
> > 
> > Link: http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=153881
> > Reported-by: Paul Menzel <pmenzel@...gen.mpg.de>
> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > ---
> >  arch/x86/pci/fixup.c |   20 +++++++++++++-------
> >  1 file changed, 13 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
> > index 837ea36..6d52b94 100644
> > --- a/arch/x86/pci/fixup.c
> > +++ b/arch/x86/pci/fixup.c
> > @@ -553,15 +553,21 @@ static void twinhead_reserve_killing_zone(struct pci_dev *dev)
> >  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x27B9, twinhead_reserve_killing_zone);
> >  
> >  /*
> > - * Broadwell EP Home Agent BARs erroneously return non-zero values when read.
> > + * Device [8086:2fc0]
> > + * Erratum HSE43
> > + * CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset
> > + * http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html
> >   *
> 
> Bjorn,
> 
> I really think you should point at this doc:
> 
> http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-datasheet-vol-2.html
> 
> Section 5.4, Device 30 Function 3
> 
> which states (at the bottom of the config space diagram) "Note: The CSR located
> at offset in Device 30, Function 3, Offset 0x10 is not a Configuration Space
> Header and SW should not treat it as such."
> 
> as it is more informative of the issue.
> 
> I'm also slightly concerned about blacklisting the rest of the config space, but
> I don't see any systems that have non-zero BARs but that's a lesser issue.
> 
> Beyond that, testing went well.

I added the link to the changelog, but I don't think it really adds
much about the issue.  It basically says "we screwed up and generic
PCI BAR sizing SW should magically ignore the register at 0x10."

Thanks for testing it; I added your Tested-by.

Bjorn