linux-kernel - Re: [PATCH v2] scsi: move function declarations to scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1vayh5zot.fsf@sermon.lab.mkp.net>
Date:   Wed, 31 Aug 2016 00:29:06 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, xie.baoyou@....com.cn
Subject: Re: [PATCH v2] scsi: move function declarations to scsi_priv.h

>>>>> "Baoyou" == Baoyou Xie <baoyou.xie@...aro.org> writes:

Baoyou> We get 2 warnings about global functions without a declaration
Baoyou> in the scsi driver when building with W=1:
Baoyou> drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype
Baoyou> for 'scsi_requeue_run_queue' [-Wmissing-prototypes]
Baoyou> drivers/scsi/scsi_lib.c:2609:6: warning: no previous prototype
Baoyou> for 'scsi_evt_thread' [-Wmissing-prototypes]

Baoyou> in fact, both functions are declared in drivers/scsi/scsi_scan.c
Baoyou> but need to move them into scsi_priv.h.

Applied to 4.9/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering