linux-kernel - Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1608454.1ZuTJsprje@amdc1976>
Date:   Thu, 01 Sep 2016 12:59:41 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:     Tomasz Figa <tomasz.figa@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
        Kukjin Kim <kgene@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        javier@....samsung.com, Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration


Hi,

On Thursday, September 01, 2016 11:21:54 AM Krzysztof Kozlowski wrote:
> Usage of DTS macros instead of hard-coded numbers makes code easier
> to read.  One does not have to remember which value means pull-up/down
> or specific driver strength.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> ---
>  arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 ++++++++++++++++++----------------
>  1 file changed, 20 insertions(+), 18 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
> index 527e3193817f..6274359fb323 100644
> --- a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
> @@ -8,6 +8,8 @@
>   * published by the Free Software Foundation.
>   */
>  
> +#include <dt-bindings/pinctrl/samsung.h>
> +
>  &pinctrl_0 {
>  	/*
>  	 * Pin banks
> @@ -83,91 +85,91 @@
>  
>  	uart0_data: uart0-data {
>  		samsung,pins = "gph-0", "gph-1";
> -		samsung,pin-function = <2>;
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;

Shouldn't macros that are also used by s3c* be named as
SAMSUNG_PIN_FUNC_2 etc. (s3c* SoCs are not Exynos)?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics