linux-kernel - Re: [PATCH] HID: usbkbd: return proper error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1609011320050.22028@cbobk.fhfr.pm>
Date:   Thu, 1 Sep 2016 13:21:42 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: usbkbd: return proper error code

On Wed, 31 Aug 2016, Sudip Mukherjee wrote:

> Use proper error code instead of using -1 on failure to allocate
> memory. We may use the error code later in the caller.

But we don't. usb_kbd_probe() returns -ENOMEM in case usb_kbd_alloc_mem() 
fails anyway, so I fail to see the point of the change really.

-- 
Jiri Kosina
SUSE Labs