linux-kernel - Re: [PATCH v2] mmc: sdhci-msm: Add pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFrdrWOkRJSL2r01eXzBQrkFm14wKn=rvABQ7EWvaNtZnQ@mail.gmail.com>
Date:   Thu, 1 Sep 2016 16:08:50 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Pramod Gurav <pramod.gurav@...aro.org>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH v2] mmc: sdhci-msm: Add pm_runtime and system PM support

[...]

>> +
>> +static const struct dev_pm_ops sdhci_msm_pm_ops = {
>> +       SET_LATE_SYSTEM_SLEEP_PM_OPS(sdhci_msm_suspend, sdhci_msm_resume)

One more thing. Why do you need the late versions of the system PM callbacks?

I think it's fine to use the regular:
SET_SYSTEM_SLEEP_PM_OPS(sdhci_msm_suspend, sdhci_msm_resume)

[...]

Kind regards
Uffe