linux-kernel - Re: [PATCH V2] staging:xgifb:remove unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160901154834.GA1977@kroah.com>
Date:   Thu, 1 Sep 2016 17:48:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ding Xiang <dingxiang@...wei.com>
Cc:     arnaud.patard@...-net.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] staging:xgifb:remove unused code

On Tue, Aug 23, 2016 at 06:23:39PM +0800, Ding Xiang wrote:
> The variable data is assigned but never used in rest code.
> 
> Signed-off-by: Ding Xiang <dingxiang@...wei.com>
> ---
>  drivers/staging/xgifb/vb_setmode.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 50c8ea4..71bb9ca 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
>  		tempax |= 0x40;
>  
>  	xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
> -	data = xgifb_reg_get(pVBInfo->P3d4, 0x07);

You didn't answer my previous question, I think this will break the
driver, have you tried this?

thanks,

greg k-h