linux-kernel - Re: [PATCH v2 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160901162634.GA12564@kozik-lap>
Date:   Thu, 1 Sep 2016 18:26:34 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Kukjin Kim <kgene@...nel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-samsung-soc@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v2 1/7] ARM: dts: exynos: Add missing memory node for
 Exynos5440 boards

On Thu, Sep 01, 2016 at 11:06:50AM +0200, Javier Martinez Canillas wrote:
> The skeleton.dtsi file was removed in ARM64 for different reasons as
> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
> 
> These also applies to ARM and it will also allow to get rid of the
> following DTC warnings in the future:
> 
> "Node /memory has a reg or ranges property, but no unit name"
> 
> But these boards don't have a memory node defined, so removing the
> skeleton.dtsi inclusion in exynos5440.dtsi will cause a change in
> the compiled DTB. Add a dummy memory node so the compiled DTB does
> not change if the skeleton.dtsi is removed from exynos5440.dtsi.
> 
> Eventually the correct starting addresses and sizes should be used
> but I didn't find that information.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> 
> ---
> 
> Changes in v2:
> - Add a fixme to specify that the correct memory values should be set.
>   (Bartlomiej Zolnierkiewicz)
> - Fix commit message (Krzysztof Kozlowski).
> 
>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 6 ++++++
>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 6 ++++++
>  2 files changed, 12 insertions(+)
>


Thanks, applied.

Best regards,
Krzysztof