linux-kernel - Re: [PATCH 9/9] serial/arc: constify uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Sep 2016 11:49:45 -0700
From:   Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:     Julia Lawall <Julia.Lawall@...6.fr>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, Jiri Slaby <jslaby@...e.com>,
        <linux-snps-arc@...ts.infradead.org>
Subject: Re: [PATCH 9/9] serial/arc: constify uart_ops structures

On 09/01/2016 10:51 AM, Julia Lawall wrote:
> Check for uart_ops structures that are only stored in the ops field of a
> uart_port structure.  This field is declared const, so uart_ops structures
> that have this property can be declared as const also.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct uart_ops i@p = { ... };
> 
> @ok@
> identifier r.i;
> struct uart_port e;
> position p;
> @@
> e.ops = &i@p;
> 
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct uart_ops e;
> @@
> e@i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct uart_ops i = { ... };
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Acked-by: Vineet Gupta <vgupta@...opsys.com>

Thx for making it better Julia !
-Vineet

> 
> ---
>  drivers/tty/serial/arc_uart.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> index 3a1de5c..5ac06fc 100644
> --- a/drivers/tty/serial/arc_uart.c
> +++ b/drivers/tty/serial/arc_uart.c
> @@ -464,7 +464,7 @@ static int arc_serial_poll_getchar(struct uart_port *port)
>  }
>  #endif
>  
> -static struct uart_ops arc_serial_pops = {
> +static const struct uart_ops arc_serial_pops = {
>  	.tx_empty	= arc_serial_tx_empty,
>  	.set_mctrl	= arc_serial_set_mctrl,
>  	.get_mctrl	= arc_serial_get_mctrl,
>