linux-kernel - Re: [PATCH] staging: ks7010: fix coding style issues in ks7010

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Sep 2016 20:19:53 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sabitha George <sabitha.george@...il.com>
Cc:     wsa@...-dreams.de, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c

On Thu, Sep 01, 2016 at 11:18:15PM +0530, Sabitha George wrote:
> This is a patch to the ks7010_sdio.c that fixes the following
> warnings found by checkpatch.pl
> 1) Missing a blank line after declarations
> 2) braces are not necessary for single statement blocks
> 3) kfree(NULL) is safe and this check is probably not required
> 4) void function return statements are not generally useful
> 5) "foo * bar" should be "foo *bar"
> 6) Code indent should use tabs where possible
> 7) printk() should include KERN_ facility level

That's 7 different things, so this should be at least 7 different
patches :)

Please break this up and submit it as a patch series so it can be easily
reviewed and applied.

thanks,

greg k-h