linux-kernel - Re: [PATCH 2/8] writeback: add wbc_to_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <774d1195-4a43-5395-14df-981336296720@fb.com>
Date:   Wed, 31 Aug 2016 21:54:14 -0600
From:   Jens Axboe <axboe@...com>
To:     Omar Sandoval <osandov@...ndov.com>
CC:     <axboe@...nel.dk>, <linux-kernel@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>, <linux-block@...r.kernel.org>
Subject: Re: [PATCH 2/8] writeback: add wbc_to_write_flags()

On 08/31/2016 05:32 PM, Omar Sandoval wrote:
> On Wed, Aug 31, 2016 at 11:05:45AM -0600, Jens Axboe wrote:
>> Add wbc_to_write_flags(), which returns the write modifier flags to use,
>> based on a struct writeback_control. No functional changes in this
>> patch, but it prepares us for factoring other wbc fields for write type.
>>
>> Signed-off-by: Jens Axboe <axboe@...com>
>> Reviewed-by: Jan Kara <jack@...e.cz>
>
> [snip]
>
>> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
>> index fc1e16c25a29..e1fc25172397 100644
>> --- a/include/linux/writeback.h
>> +++ b/include/linux/writeback.h
>> @@ -100,6 +100,14 @@ struct writeback_control {
>>  #endif
>>  };
>>
>> +static inline int wbc_to_write_flags(struct writeback_control *wbc)
>> +{
>> +	if (wbc->sync_mode == WB_SYNC_ALL)
>> +		return WRITE_SYNC;
>> +
>> +	return WRITE;
>
> I think this should be `return 0;` after the op/flags split. WRITE == 1,
> so this would get interpreted as REQ_FAILFAST_DEV in bi_opf.

Good catch, thanks! Fixed up.

-- 
Jens Axboe