linux-kernel - Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 01 Sep 2016 16:39:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dhowells@...hat.com
Cc:     netdev@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users

From: David Miller <davem@...emloft.net>
Date: Thu, 01 Sep 2016 16:38:32 -0700 (PDT)

> From: David Howells <dhowells@...hat.com>
> Date: Tue, 30 Aug 2016 16:52:39 +0100
> 
>> Don't expose skbs to in-kernel users, such as the AFS filesystem, but
>> instead provide a notification hook the indicates that a call needs
>> attention and another that indicates that there's a new call to be
>> collected.
>  ...
>> Signed-off-by: David Howells <dhowells@...hat.com>
> 
> Applied.

Actually, reverted, this adds a new warning to the build:

net/rxrpc/recvmsg.c: In function ‘rxrpc_kernel_recv_data’:
net/rxrpc/recvmsg.c:531:1: warning: label ‘need_more_data’ defined but not used [-Wunused-label]
 need_more_data:
 ^
net/rxrpc/recvmsg.c:475:7: warning: unused variable ‘no_more’ [-Wunused-variable]
  bool no_more;
       ^