linux-kernel - Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <120d69b0-4744-68f7-d524-4b7902e90ff3@osg.samsung.com>
Date:   Fri, 2 Sep 2016 01:47:16 +0200
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     David Daney <ddaney@...iumnetworks.com>,
        devel@...verdev.osuosl.org, David Daney <david.daney@...ium.com>,
        Laura Garcia Liebana <nevola@...il.com>,
        linux-kernel@...r.kernel.org,
        Aaro Koskinen <aaro.koskinen@...ia.com>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Cristina Moraru <cristina.moraru09@...il.com>,
        Philippe Reynes <tremyfr@...il.com>
Subject: Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of
 checking for built-in or module

On 09/01/2016 05:32 PM, Greg Kroah-Hartman wrote:
> On Thu, Aug 25, 2016 at 06:56:07PM -0400, Javier Martinez Canillas wrote:
>> Hello David,
>>
>> On 08/25/2016 12:01 PM, David Daney wrote:
>>> On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote:
>>>> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
>>>> built-in or as a module, use that macro instead of open coding the same.
>>>>
>>>> Using the macro makes the code more readable by helping abstract away some
>>>> of the Kconfig built-in and module enable details.
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>>>> Acked-by: David Daney <david.daney@...ium.com>
>>>>
>>>> ---
>>>>
>>>> Changes since first post:
>>>> - Added David Daney Acked-by tag.
>>>> - Rebased on top of latest master.
>>>>
>>>
>>> You changed something about the patch.  In this case the Subject is not "RESEND", but rather "v2".  Incorrect Subject lines like this can lead to the patch being inadvertently ignored.
>>>
>>
>> Yes, in fact I thought about adding a v2 suffix instead of RESEND but since
>> I didn't change the patch content (besides merge conflicts resolution), I
>> preferred to add the latter.
>>
>> I can re-spin the patch if that's an issue.
> 
> Please do.
>

Done.
 
> thanks,
> 
> greg k-h
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America