linux-kernel - Re: tools-powerpc: Return false instead of -1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbaeea41-e3a6-0469-1e3a-bfda59eb4c46@collabora.co.uk>
Date:   Fri, 2 Sep 2016 11:54:13 +0200
From:   Andrew Shadura <andrew.shadura@...labora.co.uk>
To:     Peter Senna Tschudin <peter.senna@...il.com>,
        linux-api@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     shuahkh@....samsung.com, mpe@...erman.id.au,
        sam.bobroff@....ibm.com
Subject: Re: tools-powerpc: Return false instead of -1

On 17/09/15 13:03, Peter Senna Tschudin wrote:
> Returning a negative value for a boolean function seem to have the
> undesired effect of returning true. require_paranoia_below() is a
> boolean function, but the variable used to store the return value is an
> integer, receiving -1 or 0. This patch convert rc to bool, replace -1
> by false, and 0 by true.

The issue still seems to be not fixed.

-- 
Cheers,
  Andrew