linux-kernel - Re: [PATCH] scsi: ufs: add missing declaration in ufshcd.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq18tvatvo0.fsf@sermon.lab.mkp.net>
Date:   Fri, 02 Sep 2016 06:58:55 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     vinholikatti@...il.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, arnd@...aro.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH] scsi: ufs: add missing declaration in ufshcd.h

>>>>> "Baoyou" == Baoyou Xie <baoyou.xie@...aro.org> writes:

Baoyou> We get 1 warning about global functions without a declaration in
Baoyou> the scsi ufshcd driver when building with W=1:
Baoyou> drivers/scsi/ufs/ufshcd.c:1991:5: warning: no previous prototype
Baoyou> for 'ufshcd_query_descriptor_retry' [-Wmissing-prototypes]

Baoyou> in fact, this function is implemented in ufshcd.c and exported
Baoyou> but need to be declared in header file.

ufshcd_query_descriptor_retry doesn't appear to be used outside of
ufshcd.c.

-- 
Martin K. Petersen	Oracle Linux Engineering