linux-kernel - Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <e312d810-3096-d32c-d546-c07e0265808e@samsung.com>
Date:   Fri, 02 Sep 2016 13:52:20 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Rob Herring <robh@...nel.org>, Andy Gross <andy.gross@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Clark <robdclark@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document

Hi,


On 2016-09-01 16:58, Stanimir Varbanov wrote:
> Hi,
>
> Cc: Marek
>

...

>>>> But I presume we have the implementation issue of dma_alloc_coherent()
>>>> failing in either case with the 5MB size. I think we need to look into
>>> I'd be good to include Marek Szyprowski? At least he will know what
>>> design restrictions there are.
>>>
>> Please do. The more I look at this the more I think we must use the
>> existing infrastructure for allocating "dma memory". Getting
>> dma_alloc_coherent() supporting non-power-of-2 memory regions would
> Just to be precise it should be dma_alloc_from_coherent().
>
> Marek, what is your opinion on that, can we make dma_alloc_from_coherent
> able to allocate memory for sizes with bigger granularity.
>
> For your convenience here [1] is the mail thread.

There should be no technical restrictions to add support for bigger 
granularity
than power-of-2. dma_alloc_from_coherent uses standard bitmap based 
allocator,
so it already support tracking allocations of arbitrary size. However 
for the
small allocations (smaller than 64KiB?, 512KiB?) it would make sense to keep
nearest-power-of-2 round up to prevent memory fragmentation.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland