linux-kernel - Re: [PATCH] ptrace: clear TIF_SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160902122538.GD26495@redhat.com>
Date:   Fri, 2 Sep 2016 14:25:39 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Ales Novak <alnovak@...e.cz>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jiri Kosina <jkosina@...e.cz>
Subject: Re: [PATCH] ptrace: clear TIF_SYSCALL_TRACE on ptrace detach

On 09/01, Ales Novak wrote:
>
> On __ptrace_detach(), called from do_exit()->exit_notify()->
> forget_original_parent()->exit_ptrace(), the TIF_SYSCALL_TRACE in
> thread->flags of the tracee is not cleared up. This results in the
> tracehook_report_syscall_* being called (though there's no longer a
> tracer listening to that) upon its further syscalls.
>
> Example scenario - attach "strace" to a running process and kill it (the
> strace) with SIGKILL. You'll see that the syscall trace hooks are still
> being called.

To clarify, this patch can't really fix the problem(s), The tracee can
be killed by SIGTRAP in this case. Again, we do not care too much, a lot
of bad things can happen if the tracer dies.

But I agree, this patch makes the things better for free,

Acked-by: Oleg Nesterov <oleg@...hat.com>